Release Note containing possible typo

Bug #1921448 reported by Yuko Katabami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

While translating, I've come across the following sentence which I could not comprehend:

``Users`` tab displaying all users which have roles on the project (and their roles on it), including users which have roles on the project throw their membership to a group.

Found the source here: https://github.com/openstack/horizon/blob/73f6dcebd5d81133f2604fa224f572e46da443df/releasenotes/notes/bug-1785263-46edf7313d833b4c.yaml

Is "throw" possibly a typo for "through"?
If so, my interpretation is as below. Could you please confirm if I understand it correctly?

``Users`` tab now displays all users who have roles in the project, as well as their roles in the project. This includes users who have roles in the project through their membership to a group.

Yuko Katabami (ykatabam)
description: updated
Revision history for this message
Akihiro Motoki (amotoki) wrote :

releasenotes/notes/bug-1785263-46edf7313d833b4c.yaml was added as part of bug 1785263.
Looking at https://review.opendev.org/q/topic:%22bug%252F1785263%22+(status:open%20OR%20status:merged), "through" looks the right word.

This release note is part of stein release. The release notes page is rendered based on stable branches, so we need to correct the string in stable/stein to fix it. I think we can directly correct it in stable/stein.

Changed in horizon:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: Confirmed → In Progress
Revision history for this message
Yuko Katabami (ykatabam) wrote :

Hi Akihiro-san.
Thank you for fixing the typo.
Actually I came across another segment in Horizon Release Notes that has the same typo:

``Roles assignments`` tab displaying all the roles that the users have on project or domain, directly or throw their membership to a group. When the role comes from a membership to a group this will be indicated into the role column.

(throw should be through)

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I confirmed this. After grepping the stable/wallaby branch, I see only two appearances on this, so I believe both are reported here.

$ grep -lr throw releasenotes/notes/
releasenotes/notes//bug-1785263-46edf7313d833b4c.yaml
releasenotes/notes//bug-1792524-7497aabcf6bc1e81.yaml
$ git log --oneline releasenotes/notes//bug-1792524-7497aabcf6bc1e81.yaml
9d6811945 Displays role assignment through group in user details
$ git log --oneline releasenotes/notes//bug-1785263-46edf7313d833b4c.yaml
eb4f87177 Add release note for the upgraded project detail view.

$ git tag --contains eb4f87177
$ git tag --contains 9d6811945

According to the above both commands, the oldest release corresponding to these commits are both 'stein'.
Thus, I think I can upload the above proposed fix.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/stein)

Reviewed: https://review.opendev.org/c/openstack/horizon/+/784190
Committed: https://opendev.org/openstack/horizon/commit/1c67144d19566c7144560285b4bd7d3f18c150df
Submitter: "Zuul (22348)"
Branch: stable/stein

commit 1c67144d19566c7144560285b4bd7d3f18c150df
Author: Akihiro Motoki <email address hidden>
Date: Thu Apr 1 11:57:30 2021 +0900

    Correct confusing wording in a release note

    A release note in stein has a confusig wording and I believe
    it is worth fixing though it is from some old release.
    The contents of the rendered release notes is picked up from stable
    branches, so this commit is directly proposed to stable/stein.

    Change-Id: I5c58383dec5227d0be99844e4123167a1f8c380e
    Closes-Bug: #1921448

tags: added: in-stable-stein
Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon stein-eol

This issue was fixed in the openstack/horizon stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.