Missing role assignment and group of user in the user detail view for admin

[David Gutman]

The role assignments and groups of a user are not displayed directly in the user details view for an admin user.

It could be interesting for administrator to display (by example as tabs) the list of role assignments of the user and the list of group of the user directly in the details view.

Moreover it could be interesting to indicate role assignments that the user has got through a group.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/602551

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/602552

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/602554

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/602555

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602551
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ac9335893255d5c7bbcec983ba7718e82fdedb3b
Submitter: Zuul
Branch: master

commit ac9335893255d5c7bbcec983ba7718e82fdedb3b
Author: David Gutman <email address hidden>
Date: Thu Sep 13 11:44:28 2018 +0200

    Change user details view in a tab view

    Change the existing user details view into a tabbed view with
    currently just one tab (overview tab) which presents general
    informations of the user.

    This is done to be able to add other tabs to the user details
    view.

    Change-Id: I38a33a3b218caf5d76eabd513e22aa118cc26ea1
    Partial-Bug: #1792524

[CosteijnK (costeijn-kuhlmann)]

I think there may be some regression in the change https://review.openstack.org/602551

It seems that when loading the user details the context is used from the OverviewTab.get_context_data . This results in data not showing up on the details page.

The version from this change with template to (horizon/common/_detail.html):
https://usercontent.irccloud-cdn.com/file/vRrU2l30/Screenshot%202018-12-07%20at%2016.09.00.png

When changing the template to the previous version (identity/users/detail.html)
https://usercontent.irccloud-cdn.com/file/GiTBgDlM/Screenshot%202018-12-07%20at%2016.09.30.png

Ignore the password_expires_at (that's a change i've made).

Thanks!

[David Gutman (david.gutman)]

Ok I will fix it right now, you agree it's a merge problem ? It should uses the template you have modified ?

My bug has not been closed yet so I will include a new commit to fix this.

[David Gutman (david.gutman)]

Hello CosteijnK, I've check it out and I don't understand the problem.

What is the regression in the commit ?
I've changed the template from "identity/users/detail.html" to "horizon/common/_detail.html" because the view has been changed into tab view.
The first tab of the tab view use the template 'identity/users/_detail_overview.html' which was previously used directly by "identity/users/detail.html". So the tab view continue to have the same behaviour than the previous detail view.

The only thing I can notice is that I forgot to remove the unused "identity/users/detail.html"

Tell if there is something I don't understand or I didn't see.

[Akihiro Motoki (amotoki)]

CosteijnK, David's implementation is correct. OverviewTab uses identity/users/_detail_overview.html as template_name [1]. I cannot understand the problem you mentioned in #6.

[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tabs.py#L26

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602552
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ba82055f05df0ce5bc683e8b81a05f55931f66e7
Submitter: Zuul
Branch: master

commit ba82055f05df0ce5bc683e8b81a05f55931f66e7
Author: David Gutman <email address hidden>
Date: Thu Sep 13 15:07:13 2018 +0200

    Add role assignment tab in the user details view.

    Add an extra tab "role assignments" in the user details view
    which displays all the project/role domain/role of the current
    user.

    The role assignments are displayed in a table.
    The project/domain column is clickable and forward to the project
    /domain detail view.

    Change-Id: Iefe17856e60b84d089f722c3a30e9ede21d8ce47
    Partial-Bug: #1792524
    Co-Authored-By: Akihiro Motoki <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602554
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d66df58e2d18bc01b1f04d66d19446f06e01a8d5
Submitter: Zuul
Branch: master

commit d66df58e2d18bc01b1f04d66d19446f06e01a8d5
Author: David Gutman <email address hidden>
Date: Thu Sep 13 16:01:42 2018 +0200

    Add group tab in user details view.

    Add an extra tab "groups" in the user details view which
    displays the groups of the user.

    The groups are displayed in a table which is an extansion
    (inheritance) of the group table used in the Group panel.

    Change-Id: I0ffaafaeacba0a0863c2550ac1e3649c9dd85983
    Partial-Bug: #1792524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602555
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9d681194522785331f044cee76235af91dade560
Submitter: Zuul
Branch: master

commit 9d681194522785331f044cee76235af91dade560
Author: David Gutman <email address hidden>
Date: Thu Sep 13 15:07:13 2018 +0200

    Displays role assignment through group in user details

    In the tab role assignments of the user details view, the role
    assignments the user has got through groups are added.

    In the column "role" of the table, the text "(through group GROUP_NAME)"
    is specified next to the role name.

    Change-Id: I6bbf3ef61a7c4e99e0b1ddce90ae1c12a3e18369
    Closes-Bug: #1792524

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.