Comment 3 for bug 1847959

Reviewed: https://review.opendev.org/690134
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b148c9207580731863e4dc49771e132a8c31edbc
Submitter: Zuul
Branch: master

commit b148c9207580731863e4dc49771e132a8c31edbc
Author: Matt Riedemann <email address hidden>
Date: Tue Oct 22 13:14:13 2019 -0400

    Remove dependency on novaclient list_extensions API

    The novaclient list_extensions API binding was removed in the
    16.0.0 release [1]. The ability to enable/disable extensions
    in nova has been deprecated since Liberty [2] and was removed
    in Newton [3].

    For horizon this only matters for the OPENSTACK_NOVA_EXTENSIONS_BLACKLIST
    config setting and some javascript code used to compile panels based on
    enabled extensions. In order to work with novaclient 16.0.0+, this
    change removes the list_extensions usage since all extensions
    are enabled in nova and thus for horizon a nova extension is only
    not supported if it's in the configured blacklist. To continue supporting
    the javascript code which uses the getExtensions function, the extension
    names are hard-coded. Note that the method meant to test that code,
    _test_extension_list, was wrong but never ran because of the underscore
    prefix on the method name. That is fixed here.

    [1] https://review.opendev.org/686516/
    [2] https://review.opendev.org/214592/
    [3] https://review.opendev.org/351362/

    Change-Id: Iebb1e78c718b931d632445e4de6d7a29ccb92be2
    Closes-Bug: #1847959