OpenStack Dashboard (Horizon)

  1. Bug #1748777
  2. Comment #1

Comment 1 for bug 1748777

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/543248
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0cb96af3a2a77628cd7c3147383ec7e220d49596
Submitter: Zuul
Branch: master

commit 0cb96af3a2a77628cd7c3147383ec7e220d49596
Author: wei.ying <email address hidden>
Date: Mon Feb 12 01:44:26 2018 +0800

    Admin State is always UP whatever whether router Admin State is checked or not

    On the project creation router page, if we don't check "Enable Admin
    State" option, when the router is created, "Admin State" is displayed
    as UP. This inconsistency is because the judgment condition of [1]
    doesn't hold which causes the "admin_state_up" parameter not to be
    passed by the call creation router interface. In this case, the
    back-end defaults to "admin_state_up" to be UP.

    Since the router "Enable Admin State" option has an initial value of
    True, there is no need to check for [1].

    [1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/forms.py#L121

    Change-Id: I6b95ffa680eab5c29d2bca6c91fc7f028f7f519a
    Closes-Bug:#1748777