Image is not available when launch instance

[Kairat Kushaev]

it was reproduced against master.
Steps to reproduce:
1. Go to Horizon-> Images under admin
2. Create public image of any type
3. push [Launch] button on created image.
4. go to source tab.
5. Choose Boot source= Image
6. Try to find image created in "Select one" table
AR: created image is not listed in the table
ER: created image is available in the table.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/495141

[Eugene C (hw.ewchan)]

The image should be pre-selected in the 'Allocated' section of 'Source' tab when Launch Instance is launched from Images page.

[Kairat Kushaev (kkushaev)]

So it was not,seems that the problem with racy watchers

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495141
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=48862eb9b7f5789dee3362d9103416628c5d3e76
Submitter: Jenkins
Branch: master

commit 48862eb9b7f5789dee3362d9103416628c5d3e76
Author: kairat_kushaev <email address hidden>
Date: Fri Aug 18 13:30:59 2017 +0400

    do not flush selection on "old" boot source

    This fixes an issue introduced by watchers:
    when page initialized images watchers called before
    select boot source watcher.it leads to sutiation when
    we specify selection from user input and flush it on
    updateBootSource. as a result page come to
    inconsistent state described in the bug.
    Perhaps, this requires big refactoring but in the
    current patch we do not flush selection if boot type
    was not changed. it allows to use image, snapshot,
    volume from context as ctrl.selection.

    Change-Id: I4b23071a2a9e2c02cc1f46713165e5cb5155894f
    Closes-Bug: #1710890

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/498465

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498465
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2fe66f444a35914009a275f7b8880ad12bc062d6
Submitter: Jenkins
Branch: stable/pike

commit 2fe66f444a35914009a275f7b8880ad12bc062d6
Author: kairat_kushaev <email address hidden>
Date: Fri Aug 18 13:30:59 2017 +0400

    do not flush selection on "old" boot source

    This fixes an issue introduced by watchers:
    when page initialized images watchers called before
    select boot source watcher.it leads to sutiation when
    we specify selection from user input and flush it on
    updateBootSource. as a result page come to
    inconsistent state described in the bug.
    Perhaps, this requires big refactoring but in the
    current patch we do not flush selection if boot type
    was not changed. it allows to use image, snapshot,
    volume from context as ctrl.selection.

    Change-Id: I4b23071a2a9e2c02cc1f46713165e5cb5155894f
    Closes-Bug: #1710890
    (cherry picked from commit 48862eb9b7f5789dee3362d9103416628c5d3e76)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0rc3 release candidate.

[Eugene C (hw.ewchan)]

Could we get the fix ported to ocata release as well?

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/598571

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/598571
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598571
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2ee37e5ad17204650b99ad981f84dbf2c06ad5d4
Submitter: Zuul
Branch: stable/ocata

commit 2ee37e5ad17204650b99ad981f84dbf2c06ad5d4
Author: kairat_kushaev <email address hidden>
Date: Fri Aug 18 13:30:59 2017 +0400

    do not flush selection on "old" boot source

    This fixes an issue introduced by watchers:
    when page initialized images watchers called before
    select boot source watcher.it leads to sutiation when
    we specify selection from user input and flush it on
    updateBootSource. as a result page come to
    inconsistent state described in the bug.
    Perhaps, this requires big refactoring but in the
    current patch we do not flush selection if boot type
    was not changed. it allows to use image, snapshot,
    volume from context as ctrl.selection.

    Change-Id: I4b23071a2a9e2c02cc1f46713165e5cb5155894f
    Closes-Bug: #1710890
    (cherry picked from commit 48862eb9b7f5789dee3362d9103416628c5d3e76)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon ocata-eol release.