Comment 15 for bug 1603307

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/359850
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9445d15cd133becf0137350ba843526d4548d4d0
Submitter: Jenkins
Branch: master

commit 9445d15cd133becf0137350ba843526d4548d4d0
Author: Timur Sufiev <email address hidden>
Date: Wed Aug 24 15:46:43 2016 +0300

    Fix various issues with compressed angular templates and plugins

    First, retrieve current theme only in cases when it already has been
    provided in the context. That should prevent missing 'THEME' errors
    when post_compress signal is being processed, for example inside
    _stylesheets.html which does not provide THEME var into the rendering
    context.

    Second, under certain circumstances, offline compression was producing
    a different hash for compressed angular templates than runtime
    template renderer was expecting. Make the combined template with all
    angular templates be a deterministic - convert it from a dictionary to
    a list of key-value tuples. Various order of dictionary entries in
    offline and online compress phases seemed to produce 'missing compress
    hash key' error.

    Closed-Bug: #1603307
    Change-Id: Idb48c3f68da43bba33033a71e6d69bdc112736de