commit 019e5490fbd8475483e9f33a74e127522426bec6
Author: Timur Sufiev <email address hidden>
Date: Mon Dec 5 21:05:06 2016 +0300
Remove additional response.render() for tabs
Right now TabbedView has additional .render() call. Thus
get_context_data() for TabbedView returns already rendered response
with rendered=True flag, which makes it read-only. This blocks
Profiler middleware in modifying the response. For example, we cannot
add any messages to response from tabbed view.
Simple views have no additional rendering. It was done because of
issues with raising redirect exceptions from tabbed views long
ago. Looks like now there is no such issues and raising redirects from
tabbed views is covered with unit tests. To ensure that nothing broke,
a test with a tab raising Http302 was added - it still redirects to
the url provided as before.
Reviewed: https:/ /review. openstack. org/333345 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=019e5490fbd 8475483e9f33a74 e127522426bec6
Committed: https:/
Submitter: Jenkins
Branch: master
commit 019e5490fbd8475 483e9f33a74e127 522426bec6
Author: Timur Sufiev <email address hidden>
Date: Mon Dec 5 21:05:06 2016 +0300
Remove additional response.render() for tabs
Right now TabbedView has additional .render() call. Thus context_ data() for TabbedView returns already rendered response
get_
with rendered=True flag, which makes it read-only. This blocks
Profiler middleware in modifying the response. For example, we cannot
add any messages to response from tabbed view.
Simple views have no additional rendering. It was done because of
issues with raising redirect exceptions from tabbed views long
ago. Looks like now there is no such issues and raising redirects from
tabbed views is covered with unit tests. To ensure that nothing broke,
a test with a tab raising Http302 was added - it still redirects to
the url provided as before.
Change-Id: I37076abc15008a 523f37da0d09b5b 041ef77844e
Closes-Bug: #1595095