Session timeout from AngularJS pages doesn't give user feedback

[Richard Jones]

At the moment we have very high-level code in the config() of framework.module.js which redirects the user to the login page if an API action is unauthorised (session timeout). There's no visible feedback to the user at this point though.

I think we need to move the addition of that handler to a run() so that the horizon.framework.widgets.toast.service is available and we can throw up a toast telling the user that they've been logged out. We can't include it in the config() because at that time the toast service hasn't been instantiated.

You can see this in action by loading up the swift UI and forcing a session invalidation, then clicking on some action like viewing a container contents.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Targeting to RC1 for now, but may bump. It actually handles the logout fine, but the UX for it is very unpleasant and creates a lot of confusion for the end user.

[Gloria Gu (gloria-gu)]

https://bugs.launchpad.net/horizon/+bug/1555415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/459908
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2415d5ea59a465881e10ec5a02da5d52b64d8a58
Submitter: Zuul
Branch: master

commit 2415d5ea59a465881e10ec5a02da5d52b64d8a58
Author: gugl <email address hidden>
Date: Tue Apr 25 18:14:57 2017 -0700

    Added error msg when gets redirect to login page

    This checkin includes the followings:

    1.Added an error toast message when user gets
    unauthorized 401 or 404 error during operation.

    2.When the modal dialog shows up, it also adds an error
    message at the top of the dialog.

    3.Also added some unit tests to let the coverage passes
    the threshold.

    Change-Id: I5e0962937932a21565d374561f09f98013063a4f
    Closes-bug: #1555415

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b3 development milestone.