Comment 2 for bug 1528465

Revision history for this message
Akihiro Motoki (amotoki) wrote :

At now, duplicate check for external networks is done at [2] and the comparison of network objects is checked by the logic of [1].
However, there is a case where some attributes have different values for a same object like [3]. In this case, the order of subnet lists is different.

The logic of [1] is not complete. I suggested the patch author to do so, but it is not correct.

It looks better to check network ID explicitly in dashboard/project/networks/views.py.

[1] https://github.com/openstack/horizon/blob/363a341e9a82d0864d369be84e1ba4470d049e32/openstack_dashboard/api/base.py#L169-L172
[2] https://github.com/openstack/horizon/blob/363a341e9a82d0864d369be84e1ba4470d049e32/openstack_dashboard/dashboards/project/networks/views.py#L54-L58
[3] http://paste.openstack.org/show/482640/