commit 037d1c0927b64848ea0934990ba6538d9d7a8133
Author: David Lyle <email address hidden>
Date: Wed Mar 16 10:25:26 2016 -0600
removing httplib2 test dependency
Once upon a time, the python-*client libraries were primarily built to
use httplib2. They have subsequently shift to using requests and thus
urllib3. The horizon test helpers code was maintaining a reference to
httplib2 as it intercepted errant library calls that were not mocked.
This patch removed the httplib2 dependency. Upon removing the
dependency it exposed a missed update from httplib2 to urllib3. A
function that was intended to catch unmocked calls was only listening
for httplib2 connections. This patch updates that failsafe to work with
urllib3. Upon doing so, it pointed out many, many missing mocks and in
turn, many broken tests that appeared to work because of API call
failures. This patch adds the missing mocks and fixes the broken tests.
The new failsafe prints the stack trace when an outside connection is
attempted. Additionally, to fix the fact that a missed mock used to
allow tests to potentially pass, as documented by bug 1517704, a test
failure is now forced on tests where a missing mock is detected.
Reviewed: https:/ /review. openstack. org/301862 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=037d1c0927b 64848ea0934990b a6538d9d7a8133
Committed: https:/
Submitter: Jenkins
Branch: master
commit 037d1c0927b6484 8ea0934990ba653 8d9d7a8133
Author: David Lyle <email address hidden>
Date: Wed Mar 16 10:25:26 2016 -0600
removing httplib2 test dependency
Once upon a time, the python-*client libraries were primarily built to
use httplib2. They have subsequently shift to using requests and thus
urllib3. The horizon test helpers code was maintaining a reference to
httplib2 as it intercepted errant library calls that were not mocked.
httplib2 is not actively maintained and OpenStack is moving to remove it lists.openstack .org/pipermail/ openstack- dev/2016- March/089225. html
as a dependency. See
http://
for more details.
This patch removed the httplib2 dependency. Upon removing the
dependency it exposed a missed update from httplib2 to urllib3. A
function that was intended to catch unmocked calls was only listening
for httplib2 connections. This patch updates that failsafe to work with
urllib3. Upon doing so, it pointed out many, many missing mocks and in
turn, many broken tests that appeared to work because of API call
failures. This patch adds the missing mocks and fixes the broken tests.
The new failsafe prints the stack trace when an outside connection is
attempted. Additionally, to fix the fact that a missed mock used to
allow tests to potentially pass, as documented by bug 1517704, a test
failure is now forced on tests where a missing mock is detected.
Closes-Bug: #1517704 82e0c58a3b1ab1a 6755c05adcb
Implements blueprint: remove-httplib2-dep
Change-Id: Iaabdf03966c14c