Looking more broadly at this patch, I don't think it's moving in the right direction.
If we had a working humanizeNumbers function I'd expect it to be broadly used, the same way Django's humanize filter is. It shouldn't be specifically associated with the quotas panel. If this weren't in a directory called "tech-debt" which is completely inappropriate I'd have given the patch a -2. However, the code shouldn't stay like it is.
We should either yank the broken humanizeNumbers function entirely, or place it appropriately for reuse
Looking more broadly at this patch, I don't think it's moving in the right direction.
If we had a working humanizeNumbers function I'd expect it to be broadly used, the same way Django's humanize filter is. It shouldn't be specifically associated with the quotas panel. If this weren't in a directory called "tech-debt" which is completely inappropriate I'd have given the patch a -2. However, the code shouldn't stay like it is.
We should either yank the broken humanizeNumbers function entirely, or place it appropriately for reuse
humanizeNumbers bug: https:/ /bugs.launchpad .net/horizon/ +bug/1384462