commit cf152365cd68ffa7572efa2777faf7057dccb044
Author: Alex Chan <email address hidden>
Date: Fri Mar 13 10:47:30 2015 -0700
Instance overview renders erroneous markup
Under Instance Detail | Overview | Meta | Key Name an unclosed </em>
is rendered for an instance launched without an associated key pair.
This seems to be reproducible using Django 1.6.1 in local devstack.
The issue seems to be that Django's implementation of the add filter
has an issue concatenating a string and a function to localize text.
Since that fails and returns an empty string which subsequently is
added to the closing </em> tag, the closing tag is the only thing
that is displayed.
This fix saves the localized value to a variable which is then used
in the add filter.
Reviewed: https:/ /review. openstack. org/164284 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=cf152365cd6 8ffa7572efa2777 faf7057dccb044
Committed: https:/
Submitter: Jenkins
Branch: master
commit cf152365cd68ffa 7572efa2777faf7 057dccb044
Author: Alex Chan <email address hidden>
Date: Fri Mar 13 10:47:30 2015 -0700
Instance overview renders erroneous markup
Under Instance Detail | Overview | Meta | Key Name an unclosed </em>
is rendered for an instance launched without an associated key pair.
This seems to be reproducible using Django 1.6.1 in local devstack.
The issue seems to be that Django's implementation of the add filter
has an issue concatenating a string and a function to localize text.
Since that fails and returns an empty string which subsequently is
added to the closing </em> tag, the closing tag is the only thing
that is displayed.
This fix saves the localized value to a variable which is then used
in the add filter.
Closes-Bug: #1423797 f19ae5b2bd9bcbe 2900069ac3b
Change-Id: I4452ca4a902bba