Type and Code fields' not marked manadatory in Access-Security tab

[Swati Sharma]

The 'Type' and 'Code' are the required fields for managing rules in Access and Security tab, but they do not have the asterisk marked against them.

To replicate this, please follow -
Projects -> Access and Security -> Add/Edit Rules (on any security group that has been created) -> 'Custom ICMP Rule'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/153165

[Rob Cresswell (robcresswell-deactivatedaccount)]

Patch has been inactive for many months; removing assignee so someone else can have a go.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/153165
Reason: Abandoning change, has been over 4 months since last patch set. Feel free to reactivate if you get chance to work on it again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/212444

[Lin Hua Cheng (lin-hua-cheng)]

doesn't seem impactful enough for an RC, targetting to Next release

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthias Runge (<email address hidden>) on branch: master
Review: https://review.openstack.org/212444
Reason: abandoning change due to negative feedback. vaibhav, if you intend to continue working on this patch, feel free to restore and fix the issues mentioned in the review.

[Itxaka Serrano (itxaka)]

@aniruddha-gautam do you mind if I pick up this one?

thanks!

[Itxaka Serrano (itxaka)]

Also affects:
PORT and CIDR on "Custom tcp/udp" rule adding and IP Protocol and CIDR on "Other protocol" rule adding.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/245792

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/245792
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d7e71487c3c9f270afc477e6fc43b8f923254521
Submitter: Jenkins
Branch: master

commit d7e71487c3c9f270afc477e6fc43b8f923254521
Author: Itxaka <email address hidden>
Date: Mon Nov 16 15:24:58 2015 +0100

    Set mandatory fields

    icmp_code and icmp_type fields set to required.
    Cleans both fields on rules that do not require them
    so validation for other rules still work.

    Closes-Bug: 1411566

    Change-Id: Id88eaaf5f636854d19ead4e22df8adc625d21a4b
    Signed-off-by: Itxaka <email address hidden>

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.