reduce height of text areas

Bug #1370271 reported by Cindy Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Cindy Lu

Bug Description

after the bootstrap update, the text areas all have default of 10 lines.
Some like Volume Description do not need such a large area.
In line with this patch: https://bugs.launchpad.net/horizon/+bug/1358856.

Cindy Lu (clu-m)
Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
Cindy Lu (clu-m)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122260

Changed in horizon:
status: New → In Progress
Revision history for this message
Doug Fish (drfish) wrote :

This is a really nice fix: many of our dialogs (like Create Volume) are pretty tall. This makes them fit better.

It's low risk/high value - maybe we want to target this for RC1?

Changed in horizon:
importance: Undecided → Medium
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I agree this is a nice fix. In addition I think it is a kind of degrade caused by bootstrap migration.
Previously we have description field with 4~5 lines height.

tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/122260
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d114dfe00967fa5ecb24122692c327c058ef4e23
Submitter: Jenkins
Branch: master

commit d114dfe00967fa5ecb24122692c327c058ef4e23
Author: Cindy Lu <email address hidden>
Date: Wed Sep 17 15:03:40 2014 -0700

    Reduce height for "Description" text areas

    Textarea widget defaults to 10 rows which seems unnecessary.
    Reduced to 4.

    Change-Id: I03cfd0087ffb1225c6ce893d98481a9a66e2ab3c
    Closes-Bug: #1370271

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/130948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/juno)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/130948
Reason: Gloria, I know the stable backport policy. When I propose the patch, I misunderstood this patch contained a fix for bug 1358856 (which was ugly), but it is in Juno. The remaining text areas are minor and there seems no reason to back port now.

Akihiro Motoki (amotoki)
tags: removed: juno-backport-potential
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.