height of textarea is too large

Bug #1358856 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Prasoon Telang

Bug Description

In Juno master branch, the height of textarea is 10 lines and it seems too large
when considering usecases of text areas in Horizon forms.
Especially in case where a forms has multiple textareas, e.g. "Create Network" workflow "Subnet Details" tab.

3~5 lines seems good to me.

Tags: ux
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I am not sure which is a preferred way.

(1) To set attrs rows in Django Textare.

  forms.CharField(widget=forms.Textarea(attrs={'rows': 3}),

or

(2) To set class in textarea attrs and define height in CSS.

Changed in horizon:
importance: Medium → Undecided
Changed in horizon:
assignee: nobody → Prasoon Telang (prasoontelang)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115494

David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/115494
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=05994f9d8a3f148ec0483e0ec88cfd5ce0ff7dd0
Submitter: Jenkins
Branch: master

commit 05994f9d8a3f148ec0483e0ec88cfd5ce0ff7dd0
Author: Prasoon Telang <email address hidden>
Date: Wed Aug 20 09:25:53 2014 +0530

    reduce the height of the textarea to 4

    Textarea of height 10 lines seems large considering the usecases
    in Horizon for forms containing multiple fields. Reducing it to a
    lesser value for subnet workflows in networks and images forms.

    Change-Id: I99dc6f735ed446ff4005aac7a981461c236f65b9
    Closes-Bug: 1358856

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.