Comment 5 for bug 1288419

Revision history for this message
Julie Pichon (jpichon) wrote : Re: Attaching a non-existant volume TypeError

Thanks for the reply! I agree there is a perception that one needs to leave -1s to gain respect but it doesn't work as people think it does when it's not accompanied by a meaningful comment. I think reviewers should gently be told to back off if they -1 with "I wouldn't have done this way" types of comments, and it's totally ok for the patch author to reply with "this is why it's done this way" without submitting a new patchset, as long as the explanation sounds somewhat reasonable.

I'm going to mark this bug as a low hanging fruit since it has a suggestion for the solution and is quite small. Hopefully when a newcomer picks it up they'll have a more favourable experience. Thank you for your contributions to the project and to many more!