A large project members list is hardly manageable

Bug #1269910 reported by Gabriel Briones Sayeg
44
This bug affects 6 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Joanna H. Huang

Bug Description

On Admin Projects page when a user request to modify users, a modal appears with a list of available members, the buttons may go very far down from screen if the members list is large.

Changed in horizon:
assignee: nobody → Gabriel Briones Sayeg (gbriones-gdl)
Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67315

Changed in horizon:
status: Confirmed → In Progress
Julie Pichon (jpichon)
tags: added: ux
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
Julie Pichon (jpichon) wrote :

Note a nice discussion on UX and different options on the duplicate bug 1328829.

I quite liked the patch when I tested it however it is in need of a rebase and it doesn't look like the author is around anymore. If someone wants to pick it up and co-author it to bring it to a mergeable state that'd be awesome!

Revision history for this message
Julie Pichon (jpichon) wrote :

I'm going to add the low-hanging-fruit tag, since there is already a patch that simply needs to be updated (from less to scss).

Some information on how to update an existing patch:

1. First download the patch into your local repo, you can see its id in the URL
$ git review -d 67315

2. Do your changes, test it, etc. Update the existing commit.
$ git commit -a --amend

Add the following line to the commit message (between the commit message and the ChangeId line, probably)

Co-Authored-By: Your Name <email address hidden>

Make sure the ChangeId remains the same as in https://review.openstack.org/#/c/67315/ (I33912345329cee51b9ce7cd3d658b90d08b142a5) so gerrit knows it's a new version of the same patch and reviewers have the history at hand.

3. Submit it!
$ git review

tags: added: low-hanging-fruit
Changed in horizon:
assignee: Gabriel Briones Sayeg (gbriones) → nobody
status: In Progress → Triaged
Joanna H. Huang (hhuang)
Changed in horizon:
assignee: nobody → Joanna H. Huang (hhuang)
Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Joanna H. Huang (hhuang) wrote :

Hi Julie,

I did what you suggested in your comments. I simply rebased previous patch submitted by Gabriel to the latest master and fixed the conflicts.

In respect of the height problem discussed in bug 1328829, I changed the height for the modal to '80vh', the viewport-percentage height unit introduced in CSS3: http://www.w3.org/TR/css3-values/#viewport-relative-lengths. I did a quick test on Firefox 32 and Chrome 37, and it worked fine on them. Also used http://caniuse.com/#search=vh to check the browser support. Any comments on this change are welcome.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/67315
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1f771e29ece9687fdf270f7710a8c66d383dccaa
Submitter: Jenkins
Branch: master

commit 1f771e29ece9687fdf270f7710a8c66d383dccaa
Author: Gabriel Briones <email address hidden>
Date: Thu Jan 16 16:43:55 2014 -0600

    Changed Project members list style, added scrolls

    On current implementation, when a user request to modify project
    members, a modal appears with a list of available members, the
    buttons may go very far down from screen if the members list is
    large.

    Co-Authored-By: Joanna H. Huang <email address hidden>
    Change-Id: I33912345329cee51b9ce7cd3d658b90d08b142a5
    Closes-Bug: #1269910

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.