Firewall rules are not added to policy when rules are selected in create firewall policy

[Kaiwei Fan]

When creating a firewall policy, we can select rules to be added to the policy. However after click "Add" and the policy is created, the select rules are not added to this policy.

[Akihiro Motoki (amotoki)]

The actual behavior can be fixed easily by changing "firewall_rules" to "rule" in SelectRulesStep.handle() in openstack_dashboard/dashboards/project/firewalls/workflows.py.
http://paste.openstack.org/show/47679/

However, the corresponding unit test does not work by just changing "firewall_rules" to "rule". Neutron FWaaS subteam and I are trying to fix this, but we haven't investigated the cause.

Any help will be appreciated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/49019

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/49019
Committed: http://github.com/openstack/horizon/commit/37f2916b338fe4c57c02e4985bfcd6a4dade1b04
Submitter: Jenkins
Branch: master

commit 37f2916b338fe4c57c02e4985bfcd6a4dade1b04
Author: KC Wang <email address hidden>
Date: Mon Sep 16 11:24:04 2013 -0700

    Fix add policy missing rule issue

    In firewalls/workflows.py retrieve 'rule' instead of 'firewall_rules'
    from AddPolciy post message. In test_add_policy_post, we need to
    ensure 'firewall_policy_id' field is not set before added to policy.

    Change-Id: I5f9ff81f42f4f8c7ce5c638c9074cc2dec4e1434
    Closes-Bug: #1231235