Comment 3 for bug 1415740

Revision history for this message
Kenny3794 (kenny3794) wrote :

Actually - after re-review (and using the "force" option, I change my response. I don't feel this is adequate. For, example: I have a category A with custom budget as shown:

Jan = $0
Feb = $20
March = $10
April = $0
June = $10
Jul = $10
Aug = $0
Sept = $20
...

I clearly have a budget, and some months it is 0, some > 0. However, circumstances dictate that I need to make a transaction in Jan instead of Feb. This means my Jan expenditures are over budget. The only way to show this as over-budget, is to set for the FORCE option for this and any similar budget items. But in April, I don't spend any money on this item, staying within the $0. For this case, there is no reason to show in the budget as it just crowds out valuable data with non-valuable data. I see that you have this commented out for some reason on line 799 of rep_budget.c.

Perhaps changing the || to && in the commented out code would be better (thus removing $0 budget and $0 spending from the "forced" monitoring)?

Thus, the new code on line 799 of rep_budget.c is:
    if(tmp_budget[pos] || (entry->flags & GF_FORCED && tmp_spent[pos]))

Please consider making this functionality available (or at the least, optional)