Comment 32 for bug 1006743

Revision history for this message
Miika Komu (miika-iki) wrote :

Test report:

* CASE1: I tested the branch binaries in another system where network-manager starts dnsmasq. It works as expected; installation prompts warning and dnsmasq does nothing. Success!
* CASE2: I have tested the branch binaries with in Ubuntu where I have uninstalled dnsmasq (but not dnsmasq-base), and disallowed network-manager to start it. It seems to work good. Success!

Suggestion for improvement:

* In the second case, the administrator is prompted unnecessarily. I wonder if we could test "pidof dnsmasq" instead of "dpkg -l" debian/hipl-dnsproxy.config? Please note that "service dnsmasq" does not work when network-manager starts dnsmasq.

Suggestion on how to proceed with the bug report:

* I suggest issuing a merge proposal after this small fix. Please give one week for reviews and merge if no further comments.

Good work!