Don't attempt to update tmpl ID when resource in progress
If we attempt to do a convergence update on a resource and find it already
locked by another traversal, don't try to update the resource's current
template ID or requirements data. Doing so will usually fail with the same
exception, but it is unnecessary and leaves ERROR-level messages in the
log. However, there is a race which could result in the call succeeding
(i.e. if the other task releases the lock just after we fail to get it),
and that could result in the resource not being updated at all.
Reviewed: https:/ /review. openstack. org/510674 /git.openstack. org/cgit/ openstack/ heat/commit/ ?id=79cc0cc7b93 b98ebb1e7e0d7f8 38fc1186d7bc47
Committed: https:/
Submitter: Zuul
Branch: master
commit 79cc0cc7b93b98e bb1e7e0d7f838fc 1186d7bc47
Author: Zane Bitter <email address hidden>
Date: Wed Oct 18 16:46:39 2017 -0400
Don't attempt to update tmpl ID when resource in progress
If we attempt to do a convergence update on a resource and find it already
locked by another traversal, don't try to update the resource's current
template ID or requirements data. Doing so will usually fail with the same
exception, but it is unnecessary and leaves ERROR-level messages in the
log. However, there is a race which could result in the call succeeding
(i.e. if the other task releases the lock just after we fail to get it),
and that could result in the resource not being updated at all.
Change-Id: I6bde1f9359cd52 c99cca092e8abc6 60bac8b3065
Closes-Bug: #1722371