Comment 4 for bug 1546201

Revision history for this message
Zane Bitter (zaneb) wrote :

We have some code to work around Neutron's horrible API and add an implicit dependency on any Subnets on the same network:

http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/nova/server.py?h=stable%2Fmitaka#n1045

What I suspect has happened is that the new translation rules to get rid of the separate 'network' and 'network_id' properties in OS::Neutron::Subnet mean that:

                subnet_net = (res.properties.get(subnet.Subnet.NETWORK_ID)
                              or res.properties.get(subnet.Subnet.NETWORK))

is no longer the correct logic. Note that the equivalent in OS::Neutron::Port has been changed:

http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/neutron/port.py?h=stable%2Fmitaka#n380

The race is probably very hard to reproduce, but it should be easy to detect if the dependency is being added correctly with some judiciously-placed logging.

> It would be great, if Heat could take back ownership of these tempest tests (using a tempest plugin).

I agree, but unfortunately the Tempest reviewers amongst others have prevailed upon the TC to take the opposite view: https://review.openstack.org/#/c/312718/