Comment 35 for bug 1389178

Reviewed: https://review.openstack.org/145764
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=93e05f569e29639e759ea1314af89340fee95227
Submitter: Jenkins
Branch: master

commit 93e05f569e29639e759ea1314af89340fee95227
Author: Steven Hardy <email address hidden>
Date: Thu Jan 8 12:05:15 2015 +0000

    Signal all o-a-c deployments in 99-refresh-completed

    Currently we have a TripleO specific template pattern, where all
    deployment resources are configured NO_SIGNAL, regardless of what
    DefaultSignalTransport is set to, and only one signal for all
    deployments is sent via the *AllNodesDeployment resources, by adding
    the heat-generated deploy_signal_id to the structured config data
    consumed by os-apply-config (as "completion-signal").

    This is inconsistent with all signalling done via heat-config (e.g
    everything other than o-a-c, which is triggered via a hook via
    55-heat-config, this transparently consumes the heat-generated
    deploy_signal_id and signals heat after each deployment hook is
    run.

    To allow per-deployment signalling for os-apply-config configs,
    this adds logic which looks in the deployment data processed by
    os-apply-config and signals all deployments deploying a config with
    group "os-apply-config" (everything else should be handled by 55-heat-config)

    Note that if the deployment is configured NO_SIGNAL, no deploy_signal_id
    will be set, thus this will do nothing, and currently this won't work with
    HEAT_SIGNAL, only CFN_SIGNAL (which is the default for deployments with no
    signal_transport specified). In future it would be good to add support for
    HEAT_SIGNAL to break the dependency on heat-api-cfn.

    This is backwards compatible, but after it's merged we can remove all the
    NO_SIGNAL's in the templates, and the completion-signal key from the
    allNodesConfig, which should in future allow more flexible control of
    the ordering of metadata update for configs applied via o-a-c (as well
    as better visibility of progres during deployment).

    Co-Authored-By: Dan Prince <email address hidden>

    Change-Id: I72ea524effd07deeb432fb38ee7da5f3dc7990a7
    Closes-Bug: #1389178