OS::Nova::Server used an internal coroutine to handle_delete instead of
implementing check_delete_complete. While this mostly worked, the coroutine
didn't account for errors in deletion from Nova nor did it use a timeout. This
would lead to infinite execution when servers didn't delete properly. This
patch refactors delete to use the standard handle->check lifecycle methodology
and accounts for error statuses during delete.
Reviewed: https:/ /review. openstack. org/99800 /git.openstack. org/cgit/ openstack/ heat/commit/ ?id=39425484502 38d4ac79866bb35 8a27c9d6a2ef6d
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3942548450238d4 ac79866bb358a27 c9d6a2ef6d
Author: Randall Burt <email address hidden>
Date: Wed Jun 25 12:54:22 2014 -0500
Refactor OS::Nova::Server delete handling
OS: :Nova:: Server used an internal coroutine to handle_delete instead of complete. While this mostly worked, the coroutine
implementing check_delete_
didn't account for errors in deletion from Nova nor did it use a timeout. This
would lead to infinite execution when servers didn't delete properly. This
patch refactors delete to use the standard handle->check lifecycle methodology
and accounts for error statuses during delete.
Change-Id: I6b13c1201e46c0 e73aa11e7882504 5b345931fb7
Partial-Bug: #1329453