commit 349a6f04b53309f7fa8f3225f98d41670888d20c
Author: Thomas Spatzier <email address hidden>
Date: Tue May 20 11:08:59 2014 +0200
Do no re-validate parameters for existing stacks
This patch disables validation of stack parameters values when
loading existing stacks from the database. The old behavior was
to always validate stack parameter values when initializing a
Stack object. However, this causes problems especially with
custom constraints when a constraint could be fulfilled during
stack creation but cannot be fulfilled at a later point (e.g.
when a flavor or keypair has been deleted). In such a case,
the existing stack became completely unusable.
This patch changes the behavior to not do parameter validation
for existing stacks. The assumption is that validation at stack
creation time should be sufficient to make sure the stack is valid,
so only valid stacks end up in the database. Therefore, validating
parameters again when loading stacks is not really required.
Reviewed: https:/ /review. openstack. org/94329 /git.openstack. org/cgit/ openstack/ heat/commit/ ?id=349a6f04b53 309f7fa8f3225f9 8d41670888d20c
Committed: https:/
Submitter: Jenkins
Branch: master
commit 349a6f04b53309f 7fa8f3225f98d41 670888d20c
Author: Thomas Spatzier <email address hidden>
Date: Tue May 20 11:08:59 2014 +0200
Do no re-validate parameters for existing stacks
This patch disables validation of stack parameters values when
loading existing stacks from the database. The old behavior was
to always validate stack parameter values when initializing a
Stack object. However, this causes problems especially with
custom constraints when a constraint could be fulfilled during
stack creation but cannot be fulfilled at a later point (e.g.
when a flavor or keypair has been deleted). In such a case,
the existing stack became completely unusable.
This patch changes the behavior to not do parameter validation
for existing stacks. The assumption is that validation at stack
creation time should be sufficient to make sure the stack is valid,
so only valid stacks end up in the database. Therefore, validating
parameters again when loading stacks is not really required.
Change-Id: I0947c2dcfb9db4 c81b07de582aab8 6f262d0c008
Closes-Bug: #1314401