[wishlist] Google Reader API (Feature Request)

Bug #328532 reported by Grillo
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Gwibber
Fix Released
Wishlist
Unassigned

Bug Description

I already implemented this in a branch, I would love if it could be merged.

This implementation gets the last feed titles on witch you are suscribed in Google Reader and differs the ones that are unread.

I've been using it since the last commit without any problems, please tell me your opinions

Grillo (novalkar)
Changed in gwibber:
assignee: nobody → novalkar
Revision history for this message
Dominic Evans (oldmanuk) wrote :

I had been watching your branch already, and will test the final implementation and merge it as soon as possible. Just haven't had enough time to do so yet.

Changed in gwibber:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Dominic Evans (oldmanuk) wrote :

I have now tested this branch. It works well displaying the stories in the messages feed and detailing which are read vs unread.

However, the 'read' links on each article seem to currently take you to the /reading-list page on google rather than directly to the article's original location, which I wasn't expecting the behaviour to be. Is it possible to change this to take you directly to the article whilst also marking the item as read in google reader?

Revision history for this message
Grillo (novalkar) wrote :

there is an API call to manage that :), i'll work on it

Revision history for this message
Dominic Evans (oldmanuk) wrote :

One other thing. There is currently a private bug that will need to be fixed before this merge can take place. Ryan has suggested that he expects to have it complete by this weekend, I will update the bug with this info when I have it.

Revision history for this message
Dominic Evans (oldmanuk) wrote :

"there is an API call to manage that :), i'll work on it"

Cool, many thanks for your work on this btw.

Revision history for this message
Grillo (novalkar) wrote :

I just updated the branch, please tell me if you like the way it's implemented

"Cool, many thanks for your work on this btw."

Thanks for the feedback, I learned a lot by reading the code (I learned Python a couple of weeks ago too) and I thought it would be nice to implement this functionality

Revision history for this message
Grillo (novalkar) wrote :

I kinda broke my branch, im going to clean it up and push it back up

Revision history for this message
Grillo (novalkar) wrote :

Now it's fully working, I updated it so it merges with the Gnome Keyring Update (tested it too)

Grillo (novalkar)
Changed in gwibber:
status: Confirmed → Fix Committed
Revision history for this message
Billie Thompson (billiecodes) wrote :

Hi,

This patch should fix a few issues with this feature.

* It removes the (NEW) from the titles
* gets around gwibbers issue of ignoring URL when deciding if to stack message or not
* Adds a profile image
* Adds profile link to website that originally created post

Will

Revision history for this message
Billie Thompson (billiecodes) wrote :

Balls, left a print statement in there

Revision history for this message
Billie Thompson (billiecodes) wrote :

Possibly slightly better than the previous patch, as it doesn't break the semantics to message.text.

Revision history for this message
Billie Thompson (billiecodes) wrote :

Possibly slightly better than the previous patch, as it doesn't break the semantics of message.text.

Revision history for this message
Fernando Miguel (fernandomiguel) wrote :

~/temp/1.0-url-stripping-removed-greader-fixes$ sudo python setup.py install
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    from DistUtilsExtra.command import *
ImportError: No module named DistUtilsExtra.command

Revision history for this message
Billie Thompson (billiecodes) wrote :

sudo apt-get install python-dbus python-gtk2 python-gconf python-notify python-webkitgtk python-simplejson python-egenix-mxdatetime python-distutils-extra python-feedparser

It has the same dependencies gwibber does normally

Revision history for this message
Omer Akram (om26er) wrote :

Gwibber's source have greader.py so this might be implemented back in 3.0?

Changed in gwibber:
status: Fix Committed → New
Changed in gwibber:
assignee: Grillo (novalkar) → Vadim Rutkovsky (roignac)
status: New → Confirmed
Changed in gwibber:
status: Confirmed → In Progress
Changed in gwibber:
assignee: Vadim Rutkovsky (roignac) → nobody
Bilal Shahid (s9iper1)
Changed in gwibber:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.