Comment 28 for bug 1088775

Revision history for this message
Björn Kautler (vampire0) wrote :

@Theodore

When Gwibber gets the answer from Facebook, it checks whether the answer contains a key named "privacy".
If the feed contains a key named "privacy" it reads out its subkeys "description" and "value" unconditionally, assuming they are always present.
For the "description" subkey this is not true, as it is not present, or not present anymore.
My WORKAROUND, NOT FIX as people call it, just checks for the presence of the "description" subkey before trying to read it and if it doesn't find it sets it to "Unknown". Because I don't know whether this description is relied on elsewhere in the code I do the else path with "Unknown". If the description is not used anywhere, the else path can be left out. Because of this uncertainness and because I don't want to look through all the code to find out, it is a WORKAROUND, not a proper FIX.
But it works find and doesn't mess up the security or privacy of Gwibber.