GTG

Comment 6 for bug 945553

Revision history for this message
Roquentin (antonio-roquentin-deactivatedaccount) wrote :

I did the exercice :-) it was useful but I think one can always tweak/ignore use cases to fit a pre-existing design - I swear I did not ;-)

I agree that only workview and one tag should suffice in most cases. I will leave the support for multiple tags just because it was explicitly mentioned in another report. Actually, one of the use cases gave me an idea how to make the notification area more helpful: more on this later.

Let me come back to my problem with TagCompletion because I think I need your advice. If I create an instance of TagCompletion in the plugin, the ViewTree instance inside it (called tagtree) does not emit signals when the tag_completion filter is applied. This is because the filter has been already applied to that viewtree when creating the TagCompletion instance for the modifytags. If I reset the filter every time, signals are emitted, the list store is filled correctly and tag completion works also for the instance in the plugin. The relevant piece of code is around line 83 of http://bazaar.launchpad.net/~antonio-roquentin/gtg/bugfix-945553/revision/1222/GTG/gtk/tag_completion.py. Is this solution ok for you or does it introduce other problems?

Another option would be to have an unnamed ViewTree in TagCompletion, but this will cause a problem for get_used_tags().