Comment 10 for bug 644993

Parin Porecha (parinporecha) wrote :

Atit >

I skimmed through the patch and it looks good (But, I haven't tested it yet).

some nitpicks -
- remove variable self.mi_cc1, use different name or use self.mi_cc instead. Names like this cause maintenance problems in the long run.
- Don't import all the functions into the namespace like this - from GTG.gtk.colors import *. Import only the function you need, or import the whole file like - from GTG.gtk import colors, or something like that
- Remove your comments from the code.
- Your editor is setting wrong indentation. Lines like these -


should not be in a patch