GTG

Comment 8 for bug 493835

Revision history for this message
Kevin Mehall (kevin-mehall) wrote :

Lionel> I renamed add_tag to tag_added.

Notes on call sites for the old add_tag:

./GTG/plugins/bugzilla/bugzilla.py:64: task.add_tag('@%s' % tag)
   -> "Changed" to add_tag because I think it fixes an existing bug

./GTG/plugins/rtm_sync/generic_task.py:256: map(lambda tag: self.task.add_tag('@'+tag), tags)
   -> left alone (tag_added) for now. take a look and see if this could be simplified with new add_tag

./GTG/core/dbuswrapper.py: for tag in tags: nt.add_tag(tag)
   -> used tags keyword parameter of req.new_task instead

./GTG/core/dbuswrapper.py:125: for tag in task_data["tags"]: task.add_tag(tag)
   -> should be add_tag so other apps don't have to handle this

./GTG/core/plugins/api.py:425: self.__requester.get_task(tid).add_tag("@" + tag)
./GTG/core/plugins/api.py:427: self.task.add_tag("@" + tag)
    -> "Changed" to add_tag so plugins don't need to handle this. Hopefully no breakage.

./GTG/core/requester.py:89: task.add_tag(t.get_name())
    -> Use tag_added

./GTG/core/task.py:320: task.add_tag(t.get_name())
    -> Use tag_added (under if task.can_be_deleted, so editor handles this case)

./GTG/core/task.py:512: child.add_tag(tagname)
    -> Use tag_added (this behavior probably should be discussed --
       why do we only add tags if the child has not been modified)

./GTG/core/task.py:517: if self.add_tag(tagname):
    -> tag_added (inside implementation of add_tag)

./GTG/tools/taskxml.py:61: for tag in cur_tags: cur_task.add_tag(tag)
    -> tag_added, since loaded text should already contain tags