grok

grok.Form does not implement IBrowserView

Bug #162437 reported by Christian Zagrodnick
2
Affects Status Importance Assigned to Milestone
grok
Fix Released
Undecided
Philipp von Weitershausen
0.10
Fix Released
Undecided
Philipp von Weitershausen
0.11
Fix Released
Undecided
Philipp von Weitershausen
Trunk
Fix Released
Undecided
Philipp von Weitershausen

Bug Description

grok.Form does not implement IBrowserView due to an implementsOnly. This breaks (for instance) a ViewletManager as most people assume a From would be a BrowserView :)

Christian Zagrodnick (zagy)
Changed in grok:
assignee: nobody → philipp-weitershausen
Revision history for this message
Philipp von Weitershausen (philikon) wrote :

I can confirm this:

>>> from zope.publisher.interfaces.browser import IBrowserView
>>> IBrowserView.implementedBy(grok.Form)
False

Proposed fix: Make IGrokView also inherit from IBrowserView (which is what I thought we did implicitly by inheriting from IBrowserPage, but it turns out IBrowserPage doesn't inherit from IBrowserView).

Changed in grok:
status: New → Confirmed
Revision history for this message
Philipp von Weitershausen (philikon) wrote :

Also affects 0.10.x.

Revision history for this message
Philipp von Weitershausen (philikon) wrote :

Also affects the trunk.

Revision history for this message
Philipp von Weitershausen (philikon) wrote :

Fixed on the 0.10 branch in r82097.

Revision history for this message
Philipp von Weitershausen (philikon) wrote :

Fixed on the 0.11 branch in r82098.

Revision history for this message
Philipp von Weitershausen (philikon) wrote :

Fixed on the trunk in r82100.

Jan Wijbrand Kolman (janwijbrand)
Changed in grok:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.