Comment 71 for bug 1652282

Revision history for this message
In , Curtis Gedak (gedakc) wrote :

Hi Mike,

Thank you for this updated patch set.

From a visual review I discovered only two minor typos to consider
fixing:

P4/9 - Add required polkit action file (#776437)

  intltool to 0.36.0 where it was first introduced in intllool.m4. This
                                                         ^^^
  intltool to 0.36.0 where it was first introduced in intltool.m4. This

P8/9 - Only when configured, grant root access to the X11 display (#776437)

  As an interim workaround make the gparted shell wrapper uses xhost to
                                                            ^^^
  As an interim workaround make the gparted shell wrapper use xhost to

My testing has gone fairly well. Other than the issue with 'make
distcheck', gparted is able to run on both X11 and Wayland with this
patch set.

Following are my test steps and results.

Compile with:
  $ ./configure --enable-xhost-root --prefix=/usr
  $ make
  # make install

Run with:
  gparted | sudo gparted | gparted.desktop (menu)
OR
  gparted | su -c "gparted" | gparted.desktop (menu)

Test Results:

Distro gparted sudo gparted gparted.desktop
------------ ---------------- ------------ ----------------
Debian 7 Works Works Root needed msg
Debian 9 ### Issues compiling - Bad VM??? ###
Fedora 24 Works Works Works
Fedora 25 Works Can't open display Works
openSUSE 42.1 Works Can't open display Works
openSUSE 42.2 Works Can't open display Works
Ubuntu 14.04 Root needed msg Works Root needed msg
Ubuntu 17.04 Works Works Works

Curtis