Comment 65 for bug 1652282

Revision history for this message
In , Curtis Gedak (gedakc) wrote :

Hi Mike,

The draft patch in comment #11 looks pretty good to me. I did observe two locations in the comment of P 4/7 "Add required polkit action file" where "install" should be "installed".

  Note that all polkit action files must be install in
                                            ^^^^^^^
  <snip>
  packages, action files must always be install in the same location.
                                        ^^^^^^^

I applaud your choice to require packagers to manually enable the --enable-xhost-root configure option. That way they make a conscious choice to enable the work-around to run on Wayland. Otherwise the default is not to use xhost.

I tested on fedora 25.

With --enable-xhost-root, gparted successfully runs.
Without --enable-xhost-root, gparted fails to run as it cannot open the display.

I also confirmed the issue regarding "make distcheck". It's too bad that we can't have it work both ways, but I do understand the dilemma.

Curtis