Local provider isn't usable after an old environment has been destroyed

[Björn Tillenius]

I would expect that when using the local provider, if I do 'sudo juju destroy-environment',
I can create a new local environment using 'sudo juju bootstrap'. But it doesn't seem
that works.

Let's say that I do some testing with a local provider, and I decide to start over, so I
do "sudo juju destroy-environment"

Now when I do "sudo juju bootstrap", the bootstrap itself doesn't return any error,
but looking at "juju status" after I've deployed a new service I see this:

environment: local
machines:
  "0":
    agent-state: started
    agent-version: 1.15.1.1
    dns-name: 10.0.3.1
    instance-id: localhost
    series: saucy
  "1":
    agent-state-info: '(error: container "bjorn-local-machine-1" is already created)'
    instance-id: pending
    series: precise
services:
  mysql:
    charm: cs:precise/mysql-27
    exposed: false
    relations:
      cluster:
      - mysql
    units:
      mysql/0:
        agent-state: pending
        machine: "1"

Ok, so I have to manually remove the containers, using lxc-destroy. However, that also
isn't enough, now after a new bootstrap and deploy I see this:
machines:
  "0":
    agent-state: started
    agent-version: 1.15.1.1
    dns-name: 10.0.3.1
    instance-id: localhost
    series: saucy
  "1":
    agent-state-info: '(error: symlink /var/lib/lxc/bjorn-local-machine-1/config /etc/lxc/auto/bjorn-local-machine-1.conf:
      file exists)'
    instance-id: pending
    series: precise
services:
  mysql:
    charm: cs:precise/mysql-27
    exposed: false
    relations:
      cluster:
      - mysql
    units:
      mysql/0:
        agent-state: pending
        machine: "1"

[Curtis Hovey (sinzui)]

I have seen this while testing. I cannot reliably succeed or fail.

[Geoff Teale (tealeg)]

I'm seeing this too.

[Patrick Hetu (patrick-hetu)]

It's an error in the lxc-info output parsing in the golxc package that cause this bug.

The output of lxc-info with lxc version 1.0 alpha is something like this:

Name: myusername-local-machine-1
State: RUNNING
PID: 15925
IP: 10.0.3.22

and the code that parse it is this:

    out, err := run("lxc-info", "-n", c.name)
    if err != nil {
        return StateUnknown, -1, err
    }
    kv := keyValues(out, ": ")
    state := State(kv["state"])
    pid, err := strconv.Atoi(kv["pid"])

Note that "state" and "pid" are lower case. So I think the best way to fix
that without breaking anything else is to convert the keys to lower case in the keyValues function.
I've attached a patch that does that.

[John A Meinel (jameinel)]

sounds like a reasonable patch to me. Can you propose it from a bzr branch?