critical bug (data loss!) when uninstalling on Windows

[The Escapist]

on Windows, the uninstallation routine seems to be deleting the whole GNUSim8085 directory, regardless of it containing changes to any files or even completely new files.

This is a highly critical bug, as people could possibly lose their source code/modifications this way.

The right thing to do here would be asking the user if s/he wants to retain modified/new files, and to refrain from deleting directories that contain modifications or new files.

This is the standard procedure used by other Windows installers.

[Onkar Shinde (onkarshinde)]

I never expected users to save their programs in the program directory of GNUSim8085. I thought this is what 'My Documents' folder is for. :-)
I will not fix this before 1.3.7. I have to check what kind of logic I can add in uninstaller for checking unexpected files in program folder.

[The Escapist (wisd00m)]

Fair enough, on the other hand it's worth keeping in mind that ANY file assembled by GNUSim8085 will also be IMPLICITLY SAVED, so even the examples would be updated once being run: https://bugs.launchpad.net/gnusim8085/+bug/680462

Otherwise one could just as well add a condition that checks that the files are not stored within the program directory, to avoid accidental deletion.

But with the current method of implicitly saving files before assembling, this won't work too well.

[Sridhar Ratnakumar (srid)]

I thought we recently made a change (in the NSI script) to make the
examples/ directory read-only? Isn't this targeted for 1.3.7?

On Wed, Nov 24, 2010 at 6:47 AM, The Escapist <email address hidden> wrote:
> Fair enough, on the other hand it's worth keeping in mind that ANY file
> assembled by GNUSim8085 will  also be IMPLICITLY SAVED, so even the
> examples would be updated once being run:
> https://bugs.launchpad.net/gnusim8085/+bug/680462
>
> Otherwise one could just as well add a condition that checks that the
> files are not stored within the program directory, to avoid accidental
> deletion.
>
> But with the current method of implicitly saving files before
> assembling, this won't work too well.
>
> --
> critical bug (data loss!) when uninstalling on Windows
> https://bugs.launchpad.net/bugs/680426
> You received this bug notification because you are a member of
> GNUSim8085 Administrators, which is the registrant for gnusim8085.
>

[The Escapist (wisd00m)]

I just tried the pre-release that Onkar has provided here: http://people.ubuntu.com/~onkarshinde/gnusim8085-1.3.7-without-gtk-installer.exe

I can confirm that this practice of automatically saving each assembled file causes errors on Windows, once the examples are being run.

[Sridhar Ratnakumar (srid)]

Maybe examples/ could instead be installed to the 'My Documents' (or
%LOCALAPPDATA%') directory?

On Fri, Nov 26, 2010 at 7:18 AM, The Escapist <email address hidden> wrote:
> I just tried the pre-release that Onkar has provided here:
> http://people.ubuntu.com/~onkarshinde/gnusim8085-1.3.7-without-gtk-
> installer.exe
>
> I can confirm that  this practice of automatically saving each assembled
> file causes errors on Windows, once the examples are being run.
>
> --
> critical bug (data loss!) when uninstalling on Windows
> https://bugs.launchpad.net/bugs/680426
> You received this bug notification because you are a member of
> GNUSim8085 Administrators, which is the registrant for gnusim8085.
>

[The Escapist (wisd00m)]

on windows, that would propbably be a good compromise