Glyphicus

Bug #521471
Comment #6

Comment 6 for bug 521471

Revision history for this message

Jefficus (jeff-smithicus) wrote on 2010-04-14: Re: [Bug 521471] Re: Order annotations in tree by span start

Nikolai: the doc_id is the id of the annotation. The link_doc_id is the id
of the target doc. So if you have a doc with the same doc_id and
link_doc_id, it would specify a doc annotating itself.

Why does the display need to be refreshed? When you create a new annotation,
why can't it insert itself into the tree at the correctly sorted location?

We have discussed the possibility of having many-to-many comment linkages
before, but we've never really made a decision. Given the increased
complexity that implies for the UI, I think we should decide to limit
ourselves to one-to-one linking for now.

On Tue, Apr 13, 2010 at 11:13 PM, Nikolai Roman <email address hidden>wrote:

> I have partially fixed the bug. The program runs with some exceptions.
> The annotations are arranged according to their target span. If you add
> new annotations, you have to reopen the project to see the correct
> ranking of the annotations. However, due to the database design, we
> could create several annotations whose doc_id and link_doc_id are the
> same, which means that the relations between documents and annotations
> are "one-to-many". This relation leads to certain incorrect ranking of
> the annotations whose doc_id and link_doc_id are the same. Is this what
> we want? If we want to implement annotation for annotation, then we
> should have a "one-to-one" relation between documents and annotations,
> right?
>
> In addition, when the user clicks one annotation to open it, the program
> will generate a java.lang.IllegalStateException: Attempt to mutate in
> notification, which does not affect the functionality of the program.
>
> I have put all the relevant comments about the target span ordering
> implementation into "TODO" comments in the source code, which could be
> reviewed from selecting the menu item "Tasks" in Netbeans.
>
> ** Changed in: glyphicus
> Status: In Progress => Fix Committed
>
> --
> Order annotations in tree by span start
> https://bugs.launchpad.net/bugs/521471
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
Jeff Smith
Computer Science Dept.
University of Saskatchewan
Phone: 306-665-8157

Nikolai: the doc_id is the id of the annotation. The link_doc_id is the id
of the target doc. So if you have a doc with the same doc_id and
link_doc_id, it would specify a doc annotating itself.

Why does the display need to be refreshed? When you create a new annotation,
why can't it insert itself into the tree at the correctly sorted location?

On Tue, Apr 13, 2010 at 11:13 PM, Nikolai Roman <xiaonuo.gantan@gmail.com>wrote:

> I have partially fixed the bug. The program runs with some exceptions.
> The annotations are arranged according to their target span. If you add
> new annotations, you have to reopen the project to see the correct
> ranking of the annotations. However, due to the database design, we
> could create several annotations whose doc_id and link_doc_id are the
> same, which means that the relations between documents and annotations
> are "one-to-many". This relation leads to certain incorrect ranking of
> the annotations whose doc_id and link_doc_id are the same. Is this what
> we want? If we want to implement annotation for annotation, then we
> should have a "one-to-one" relation between documents and annotations,
> right?
>
> In addition, when the user clicks one annotation to open it, the program
> will generate a java.lang.IllegalStateException: Attempt to mutate in
> notification, which does not affect the functionality of the program.
>
> I have put all the relevant comments about the target span ordering
> implementation into "TODO" comments in the source code, which could be
> reviewed from selecting the menu item "Tasks" in Netbeans.
>
> ** Changed in: glyphicus
>       Status: In Progress => Fix Committed
>
> --
> Order annotations in tree by span start
> https://bugs.launchpad.net/bugs/521471
> You received this bug notification because you are a direct subscriber
> of the bug.
>

-- 
Jeff Smith
Computer Science Dept.
University of Saskatchewan
Phone: 306-665-8157