Buildserrors with Xulrunner 22

[Thaodan]

Building with Xulrunner 22 causes build errors. To fix this build without linking to xpcom.
This fixes the build error and leaves the extension in a working state. The only issues that this causes are that the content of sub-menus is not updated some time., but If the menu is used the sub-menus get updated. Here a patch to fix configure.

[Chris Coulson (chrisccoulson)]

Note, this addon is basically abandoned now as it has become a nightmare to support. I already had to remove functionality due to Mozilla bug 757485. Mozilla bugs 790978, 830231 and 836050 have all required fairly messy workarounds just to keep it going.

Mozilla bug 826093 will mean that you have to rip out menu icon support in Firefox 23.

I gave up trying to maintain an addon for this. We ship a patch for this in Ubuntu now: http://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/view/head:/debian/patches/unity-menubar.patch

(see https://bugzilla.mozilla.org/show_bug.cgi?id=619899 , although the patch attached to that bug is quite outdated now)

[Thaodan (theodorstormgrade)]

Is this patch unity only like the replacement of appmenu-gtk?

[Chris Coulson (chrisccoulson)]

I'm not really sure what you're asking. The patch works the same as the addon, the only difference is that it isn't a total mess

[Thaodan (theodorstormgrade)]

I asked if the patch is unity only like the replacement for appmenu-gtk: https://launchpad.net/unity-gtk-module
I asked cause I'm a KDE user. But as it works like addon it should work with KDE and co. I'll try it.

[John Rose (johnaaronrose)]

I am not a developer. So could someone please explain how to implement this patch? When will it be implemented into 64 bit Precise?

[Thaodan (theodorstormgrade)]

I just removed libxpcom as library to link, as the functionailty is already provided by an other lib. You don't need this if you use the standard ubuntu package as on this package is a patch applied which brings the same functionality (see above why).

[Thaodan (theodorstormgrade)]

Chris, do I need to do something to use this patch as I get this when using it and building libxul?

[Thaodan (theodorstormgrade)]

I found the error I had to enable gio,

[Thaodan (theodorstormgrade)]

Is that normal that the menu sometimes doesn't works?