Comment 32 for bug 1757517
Revision history for this message
|
|
#32 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
(In reply to comment #27)
> Created attachment 6363 [details]
> Proposed fix that only adds to the stack size if it's less than 16 times
> __static_tls_size
>
> This patch checks if the stack size is less than 16 times the
> __static_tls_size, and adds to it in that case.
>
> Carlos, I know you're working on this for trunk, but we'd like a fix for
> ChromeOS.
>
> What are your thoughts about this patch, Paul/Carlos/Mike?
Your proposed patch seems like a fine temporary solution for the ChromeOS threads.
There is no ABI here so you can feel free to patch locally and use that to fix the problem.
I would like to more carefully evaluate the heuristic and the point at which we go from old to new behaviour and make that deterministic instead of dependent on the size of a random variable (in the statistical sense).
To be clear I would not accept your patch for trunk.