Glance

  1. Series havana
  2. Bug #1298698
  3. Comment #17

Comment 17 for bug 1298698

Revision history for this message
Tristan Cacqueray (tristan-cacqueray) wrote : Re: Remote Code Execution in Sheepdog backend (CVE-2014-0162)

@Zhi Yan Liu About your fix, why did you renamed configure_add in configure, and removed the sheepdog.Store stubs in tests ? It seems to make thoses tests fail:

- glance.tests.functional.store.test_filesystem.TestFilesystemStore
- glance.tests.functional.store.test_http.TestHTTPStore
- glance.tests.unit.test_store_base.TestStoreBase
- glance.tests.unit.test_store_location.TestStoreLocation

Also, I think it misses a expect OSError after the processutils.execute. Without shell=True, execute raises OSError instead of ProcessExecutionError and it makes this test fail:

- glance.tests.functional.store.test_sheepdog.TestSheepdogStore

Do you have thoses errors as well ?