Comment 58 for bug 1996188
Revision history for this message
| Rajat Dhasmana (whoami-rajat) wrote Re: Arbitrary file access through custom VMDK flat descriptor | #58 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
For the cinder patch, I've a doubt as follows:
In new method check_image_format
+ if image_id is None:
+ image_id = 'internal image'
In which case we need to do this? If the image_id doesn't exist, it should be an error right? IIUC this is called from convert_image which can only be called by download image/upload volume which should have the image ID.
Even if there is a case where this can be None, shouldn't we assign a UUID instead of a string 'internal image' here? Else this will fail for the second image since 'internal image' ID is already used by the first image created with this flow.