Comment 47 for bug 1996188
Revision history for this message
| Brian Rosmaita (brian-rosmaita) wrote Re: Arbitrary file access through custom VMDK flat descriptor | #47 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Another update ... this one moves the check that the source_format (if specified) matches what qemu-img info thinks is the image format. I was hesitating because it requires an extra call out to qemu-img, but the caller can get around that by passing the qemu_img_info data if it's already available. Plus, relative to the time to actually do a conversion of a large image, this is negligible. But given the bad stuff that Guillaume and Arnaud discovered about what can happen when there's a mismatch, I figure it's definitely worth checking in convert_image().