Comment 6 for bug 1765748
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #6 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 5b00f19109b5f4d
Author: Chris Dent <email address hidden>
Date: Wed Apr 25 16:26:53 2018 +0100
Make accept-language tests work with webob 1.8.x
webob 1.8.x has altered its processing for accept-* headers [1],
including being less accomodating of less than well-formed qvalues.
If it is unable to parse a header, rather than raising an error of
anything like that, a special class of header is created instead.
This header still responds on all the same methods as before, but with
different results. In the big picture this is a good thing (for
correcting processing for content-
for us.
This change fixes the immediate short term problem, broken unit tests,
by fixing their bad qvalues. The new values will continue to work with
old webob. We can hope/assume that most clients will send well-formed
qvalues.
Longer term we will need to address how the nova Request object is
choosing to do best match handling on accept headers to address that
webob has deprecated (with a long warning period) methods used by the
object.
Partial-Bug: #1765748
[1] https:/
Change-Id: I2034d30cc8d935