Reviewed: https://review.openstack.org/548576 Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=403ec94bc1a28e168dc074fe98cadc0e0766f85c Submitter: Zuul Branch: stable/queens
commit 403ec94bc1a28e168dc074fe98cadc0e0766f85c Author: ForestLee <email address hidden> Date: Mon Jul 17 19:03:02 2017 +0800
Add a hacking rule for string interpolation at logging
String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. See the oslo i18n guideline * https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#adding-variables-to-log-messages and * https://github.com/openstack-dev/hacking/blob/master/hacking/checks/other.py#L39 Closes-Bug: #1596829
Change-Id: Ibba5791669c137be1483805db657beb907030227
Reviewed: https:/ /review. openstack. org/548576 /git.openstack. org/cgit/ openstack/ watcher/ commit/ ?id=403ec94bc1a 28e168dc074fe98 cadc0e0766f85c
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 403ec94bc1a28e1 68dc074fe98cadc 0e0766f85c
Author: ForestLee <email address hidden>
Date: Mon Jul 17 19:03:02 2017 +0800
Add a hacking rule for string interpolation at logging
String interpolation should be delayed to be handled by /docs.openstack .org/oslo. i18n/latest/ user/guidelines .html#adding- variables- to-log- messages /github. com/openstack- dev/hacking/ blob/master/ hacking/ checks/ other.py# L39
the logging code, rather than being done at the point
of the logging call.
See the oslo i18n guideline
* https:/
and
* https:/
Closes-Bug: #1596829
Change-Id: Ibba5791669c137 be1483805db657b eb907030227