Comment 74 for bug 1596829

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/484250
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d02a66d6bf1d222db23d1c14f8c0b53564d28cf2
Submitter: Jenkins
Branch: master

commit d02a66d6bf1d222db23d1c14f8c0b53564d28cf2
Author: ForestLee <email address hidden>
Date: Mon Jul 17 13:39:19 2017 +0800

    Add a hacking rule for string interpolation at logging

    String interpolation should be delayed to be handled by
    the logging code, rather than being done at the point
    of the logging call.
    See the oslo i18n guideline
    * https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#adding-variables-to-log-messages
    and
    * https://github.com/openstack-dev/hacking/blob/master/hacking/checks/other.py#L39
    Closes-Bug: #1596829

    Change-Id: Iba231be2476dcbeeb0edd76d6a921e549d183758