Comment 45 for bug 1593799

Revision history for this message
Stuart McLaren (stuart-mclaren) wrote :

This is a good catch (kicking myself I didn't see it).

We probably don't want a major rewrite of the wording at this point.

If it's possible to make one change I think "publish" in this sentence is not well defined:

 "if the environment allows non-administrators to publish images"

Really, we want "publicize" or "create public images" here, because some people will probably interpret "publish" as regular create or upload. I'd like to see this changed if it's possible.

Less importantly, image sharing is also controlled by policy (we actually disable it by default) so if you also have it disabled you're unaffected. We could add an equivalent "if the environment allows image sharing". (Though this is probably fairly obvious).

For any future notifications it may be good practice to explicitly name the various policies ("publicize_image"/"add_member") we may be implying.

Would it be worthwhile to update the db purge code? (If so, I may be able to find a volunteer.)

Thanks.