I stand corrected on the point # 3 where the right answer is shared images "do not" come under this umbrella:
https://github.com/openstack/glance/blob/b55dd079e02a9c78b82d7e341d3cc51e6cbadab1/glance/db/sqlalchemy/api.py#L280-L291
So the case for community and shared images is same (i.e point #2 & #3 can be combined)
Overall, I think we can go with what we have plus the changes Brian suggested 36, 37 and 39.
I stand corrected on the point # 3 where the right answer is shared images "do not" come under this umbrella:
https:/ /github. com/openstack/ glance/ blob/b55dd079e0 2a9c78b82d7e341 d3cc51e6cbadab1 /glance/ db/sqlalchemy/ api.py# L280-L291
So the case for community and shared images is same (i.e point #2 & #3 can be combined)
Overall, I think we can go with what we have plus the changes Brian suggested 36, 37 and 39.