Comment 9 for bug 1516706

Hi Hemanth. Thanks a lot for the comment.

So the issue is the call to db.get_api().
v1 api ends up either talking directly to db (which should not be the case) or it ends up talking to registry v2 client (which again is not what it should be doing) cos of whatever has been given to data_api.
So basically the 5 opts enable_v1_api, enable_v2_api, enable_v2_api, enable_v2_registry and data_api are not working well together.

I think we should be making a decision in db.get_api() or after the call to db.get_api() as to whether return 'data_api' as it is (we want this when v2 reg is making the call) or if we need to direct it to v1 registry client which will then route to db.
In brief, a couple of additional checks whenever db.get_api is called from either v1/images or v2/images.

And regarding the proposed change , I agree that it will not let registry to serve all alone. But I also feel that we need to have a warning issues at the least that v1 registry is running alone without v1 api.

Let me know what you think.