Comment 3 for bug 1441453

Revision history for this message
Flavio Percoco (flaper87) wrote :

I don't think this is an liberty-rc-potential. I'm copying here my feedback on the review:

TBH,

I don't feel comfortable merging this patch as part of RC2. I'm happy to be convinced otherwise but it seems to me it's a bit invasive and it does not feel like a bug fix but rather a "feature" implementation.

I understand this is needed by SearchLight and the motivations behind it but:

1) It's refactoring part of the image members code (specifically the MemberRepo) 2) It adds a new MemberRepo for sending notifications, which is required for this to work but, there hasn't been a bit of discussion on whether sending members information is fine and nor about the format of these notifications.

If you think I'm being super paranoid, please, let me know. But, for an RC2, this just feels too much and it doesn't feel like a bug fix but rather like something that could use a lite-spec (if we had them).