causes this filter query to go against the models.Image member is_public, and not the properties. This causes some unexpected results. In v2 a user providing the is_public filter should be querying their own properties and not the state which is set by 'visibility' .
should we disallow the usage of the property with the name 'is_public' in order to avoid this confusion? Or should we allow the use of it an have some special case logic to handle is_public specifically (I think that is the only one).
This makes it hard to deal with the is_public as mentioned in this bug: https:/ /bugs.launchpad .net/glance/ +bug/1154760
The following can happen in the current code base.
A user queries for an image using the v2 API and sets the filter is_public=foo. The logic here:
https:/ /github. com/openstack/ glance/ blob/master/ glance/ db/sqlalchemy/ api.py# L583
causes this filter query to go against the models.Image member is_public, and not the properties. This causes some unexpected results. In v2 a user providing the is_public filter should be querying their own properties and not the state which is set by 'visibility' .
should we disallow the usage of the property with the name 'is_public' in order to avoid this confusion? Or should we allow the use of it an have some special case logic to handle is_public specifically (I think that is the only one).