Comment 9 for bug 1157765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/25371
Committed: http://github.com/openstack/glance/commit/9f336df06409b4e37e1737978cf7187a4172ca74
Submitter: Jenkins
Branch: milestone-proposed

commit 9f336df06409b4e37e1737978cf7187a4172ca74
Author: Flaper Fesp <email address hidden>
Date: Thu Mar 21 10:05:05 2013 +0100

    Check if creds are present and not None

    Currently, KeystoneStrategy checks whether the required credentials are
    present in the creds dict but it doesn't check whether they are valid or
    not.

    This patch checks whether the required creds are present and not None
    otherwise a MissingCredentials exception will be raised.

    Note: No need for checking parameters' values types since they'll be
    instances of basestring once set otherwise they'll be None.

    Fixes bug 1157765

    Change-Id: I664a604c3cbf2fca60a88c4d887cd9a4b678c8a5
    (cherry picked from commit 855162b0b1fc62b60f0f350d3258334711e12aec)